feat(device): refactor and enhance view hierarchy XML generation. #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed PR Fixed android tests fix(android): `device.getViewHierarchyXML` return value. Fixed tests once again fix curly brackets.
Jest's API is not good enough and causing test runs to fail on warnings for unused snapshots.
asafkorem
force-pushed
the
feat/inject-test-id
branch
from
6d5910e
to
056bc77
Compare
gosha212
reviewed
Sep 1, 2024
| endDocument() | ||
| } | ||
|
|
||
| writer.toString() |
There was a problem hiding this comment.
Are you sure that flush is not needed here?
There was a problem hiding this comment.
good point, it does has flush() method since it inherits from Write (flush is abstract), but it means nothing this case since it immediately writes to an in-memory resource (the string), so there's nothing to flush
| serializer.endTag("", view.javaClass.simpleName) | ||
| } | ||
|
|
||
| private fun serializeViewAttributes( |
There was a problem hiding this comment.
Wow. Great utilization of kotlin syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getViewHierarchyXmlability to inject test-IDs while traversing the tree. This injection is a side-effect of the generation process to optimize performance.getViewHierarchyXmltogenerateViewHierarchyXml(shouldInjectTestIds = false)to accurately represent the method's functionality.