Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test build type in proguard config documentation #4501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erksch
Copy link

@erksch erksch commented Jun 2, 2024

Description

I followed the guide on proguard configuration and noticed an issue in the docs where the testBuildType parameter is not correct.

It is

{
  apps: {
     'android.release': {
       type: 'android.apk',
-      binaryPath: 'android/app/build/outputs/apk/release/app-release.apk',
+      binaryPath: 'android/app/build/outputs/apk/releaseE2E/app-releaseE2E.apk',
-      build: 'cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release'
+      build: 'cd android && ./gradlew assembleReleaseE2E assembleAndroidTest -DtestBuildType=release'
     },`

but should be

{
  apps: {
     'android.release': {
       type: 'android.apk',
-      binaryPath: 'android/app/build/outputs/apk/release/app-release.apk',
+      binaryPath: 'android/app/build/outputs/apk/releaseE2E/app-releaseE2E.apk',
-      build: 'cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=releaseE2E'
+      build: 'cd android && ./gradlew assembleReleaseE2E assembleAndroidTest -DtestBuildType=releaseE2E'
     },`

Otherwise the android test APK for the releaseE2E variant is not created.

You can see that others already use this for example here: #3711

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

@erksch erksch requested a review from d4vidi as a code owner June 2, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant