Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): add web-view testing support. #4394

Merged
merged 72 commits into from
Mar 12, 2024
Merged

feat(ios): add web-view testing support. #4394

merged 72 commits into from
Mar 12, 2024

Conversation

asafkorem
Copy link
Contributor

@asafkorem asafkorem commented Mar 11, 2024 •
edited
Loading

In this pull request, I've:

  • Added support for web-view testing on iOS, achieving feature parity with Android.
  • Introduced a new fancy test suite for full coverage of Detox web-view APIs.
  • Updated documentation to reflect these changes.

TODOS (in this PR):

  • Add missing unit tests (JS).
  • Ensure Android pass the new test suite.

Follow-ups:

  • Write a post about this new support in our Blog page.

@asafkorem
docs(web-views): improve and update (iOS support).
367b42a
@asafkorem
docs(webviews): fix redundant empty line.
d74f7bf
@asafkorem
test(e2e, webviews): enable on ios.
4e3d3ed
@asafkorem
feat(webviews): add trace descriptions.
309d981
@asafkorem
test(e2e): enable webview tests on iOS.
8516b17
@asafkorem
feat(ios): add web-expect and web-action APIs.
a8316bd
@asafkorem
test(unit, ios): test web-view apis.
d49b053
@asafkorem
iOS(WebJSCodeBuilder): initial commit.
0721463
@asafkorem
feat(ios): add web-view utils for WKWebView.
6e6eba5
@asafkorem
feat(ios): add WebExpectation, route from InvocationManager.
eea60a9
@asafkorem
feat(iOS): make web-view interaction work.
7e5c5f2
@asafkorem
fix(ios): handle async actions on web-view expectation JS evaluation.
2543268
@asafkorem
feat(ios): introduce web actions.
db60bb2
@asafkorem
feat(ios, webviews): make runscript work.
18c20fc
@asafkorem
fix(ios, webview): fix web-view matching with element matcher.
68e94c6
@asafkorem
fix(ios, webview): improve element-not-found error.
a4acd73
@asafkorem
refactor(ios, webview): extract WebInteraction.
c18fe6e
@asafkorem
refactor(ios, webview): extract WKWebView utils.
d7f3d9d
@asafkorem
refactor(ios, webview): extract findView method.
1e6ca9b
@asafkorem
refactor(ios, webview): extract methods.
9c48f33
@asafkorem
fix(ios, webview): fix type text.
8f51173
@asafkorem
fix(test): export error.
dc3482f
@asafkorem
feat(test): duplicate WebViewScreen to WebViewScreenV2.
e49dc05
@asafkorem
feat(ios, webview): add tests.
49ed906
@asafkorem
test(e2e): extract common code.
81d96b3
@asafkorem
test(e2e): extract snapshot util.
03d5c28
@asafkorem
docs(webviews): clarify android-only limitations.
74a3470
@asafkorem
text(e2e): fix snapshot util.
f47d0c5
@asafkorem
refactor(ios): introduce web action creation methods.
36b6361
@asafkorem
refactor(ios): improve web-view action error message.
fbb9b58
@asafkorem asafkorem mentioned this pull request Mar 11, 2024
Closed
This was linked to issues Mar 11, 2024
Web testing for iOS #4134
Closed
Add E2E tests coverage for webviews API #3751
Closed
Web View interaction on iOS #3030
Closed
@asafkorem asafkorem marked this pull request as ready for review March 11, 2024 21:01
asafkorem
asafkorem commented Mar 11, 2024
View reviewed changes
detox/test/e2e/utils/snapshot.js
@@ -0,0 +1,58 @@
const fs = require('fs-extra');
const { ssim } = require('ssim.js');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this util for image comparison

Copy link
Collaborator

@noomorph noomorph Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Optional) I would advise eventually to use https://github.com/americanexpress/jest-image-snapshot instead of low-level wrappers.

@asafkorem asafkorem merged commit 715d100 into master Mar 12, 2024
7 checks passed
@asafkorem asafkorem deleted the feat/ios-web-views branch March 12, 2024 06:35
@asafkorem asafkorem self-assigned this Mar 12, 2024
@asafkorem
Copy link
Contributor Author

It will be released today in the upcoming version.

@asafkorem
Copy link
Contributor Author

asafkorem commented Mar 12, 2024 •
edited
Loading

Follow-up on Android issues: #4398, #4397

asafkorem added a commit that referenced this pull request Mar 12, 2024
@asafkorem
Merge pull request #4399 from wix/webview-review-fixes
fa52090 
fix(webviews): apply suggested changes from #4394.
@asafkorem
Copy link
Contributor Author

asafkorem commented Mar 13, 2024 •
edited
Loading

Released with v20.19 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noomorph noomorph noomorph left review comments

@d4vidi d4vidi Awaiting requested review from d4vidi d4vidi is a code owner

Assignees

@asafkorem asafkorem

Labels
platform: ios type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web testing for iOS Add E2E tests coverage for webviews API Web View interaction on iOS
2 participants
@asafkorem @noomorph