fix(iOS): migrate (some) device commands to Simctl. #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
changed the title
asafkorem
changed the title
This was referenced Dec 19, 2023
|
CI fails due to build issues, Xcode 15 is required. Already asked @igorgn to upgrade OSS agents to latest Xcode. |
asafkorem
force-pushed
the
fix/ios17-permissions
branch
from
853709a to
6c60129
Compare
asafkorem
force-pushed
the
fix/ios17-permissions
branch
from
4ec9c62 to
d2d143b
Compare
Replace native module with react-native-permissions module.
This reverts commit b556905.
react-native-permissions enabled this feature in https://github.com/zoontek/react-native-permissions/releases/tag/4.0.2.
asafkorem
force-pushed
the
fix/ios17-permissions
branch
from
fea7ff5 to
90c6756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Simctl instead of ASU (AppleSimUtils) where possible, utilizing Simctl capabilities like setting the Simulator geo-location (which wasn't possible before).
Also, add E2E tests for setting device permissions.