Fix leaking graphs when classes are injected by lifecycle bound graphs #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a React construct component is injected by a lifecycle bound graph, the graph is retained in memory until the React construct is unmounted. Injecting regular classes also contributed to the retention count which caused a bug as graphs are released on unmount.
guyca
force-pushed
the
fixLeakWhenInjectingClasses
branch
from
df4964e
to
d551bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a React construct component is injected by a lifecycle bound graph, the graph is retained in memory until the React construct is unmounted.
Injecting regular classes also contributed to the retention count which caused a bug as graphs are released on unmount.
This commit retains graphs only if the injection target is a React class component.