Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(language-server): move @volar/typescript as dev dep #954

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 20, 2024

Changes

Lame PR 😅 but @volar/typescript was only used as types so we move it as a dev dep. It's still used transitively by @volar/language-server and @volar/kit, so not removed from the dependency graph

Testing

Manually checked that it's not used in the compiled js or dts files.

Docs

n/a

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 14a1b57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll allow it

@Princesseuh Princesseuh merged commit 0c3f30e into main Sep 20, 2024
4 checks passed
@Princesseuh Princesseuh deleted the volar-typescript-dev branch September 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants