Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve deploy workflow #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Dec 8, 2023

@alexanderniebuhr
Copy link
Member Author

alexanderniebuhr commented Dec 8, 2023

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexanderniebuhr and the rest of your teammates on Graphite Graphite

@mandar1jn
Copy link
Collaborator

Shouldn’t all plaintext cars be set in wrangler.toml instead of in the workflow and github secrets?

@alexanderniebuhr
Copy link
Member Author

Shouldn’t all plaintext cars be set in wrangler.toml instead of in the workflow and github secrets?

In theory yes, but I don't want to do that change in the same PR, right now everything works with them being secrets, adding those to wrangler.toml as vars now, could lead to other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants