Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation to inline svg #10858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Its-Just-Nans
Copy link

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d539fb
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/679cba8023e1e6000891f3f6
😎 Deploy Preview https://deploy-preview-10858--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Thank you for providing more helpful context about using inline SVGs! As this is documentation for an experimental, and actively developing feature, it is not intended to be perfectly complete to allow for the greatest flexibilty while the feature is being worked on and may yet still change in significant ways. And we do encourage people to go check the roadmap proposals for more information, relying on docs only for basic implementation at this stage.

I checked the linked comments, and I see much of this conversation takes place in an open proposal for a feature, and discussion of a temporary workaround. Normally, we will only add to documentation when this is a supported, recommended procedure to follow that we don't expect to change too much.

So, while this is a solution, I'm not sure from that discussion whether we would consider this something to document yet as our official method, or whether a different proposed solution is in the works.

I'll ask @Princesseuh whether she would suggest adding this information to our formal documentation at this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants