-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update guides/deploy/cloudflare.mdx
#10790
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thank you for contributing this! I will ask for feedback from others who use Cloudflare to confirm the steps! Perhaps @alexanderniebuhr is able to verify here? |
I think for users with multiple accounts this is different. I'll check tomorrow my time :) |
Just checked it on my Cloudflare Account with Multiple accounts and it looks just fine to me. |
|
||
3. Log in to the Cloudflare dashboard and select your account in **Account Home** > **Compute (Workers)** > **Workers & Pages** > **Overview**. | ||
3. Go to **Account Home** > **Compute (Workers)** > **Workers & Pages**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to go to the Account Home
menu, let me know if you have any other thoughts.
3. Go to **Account Home** > **Compute (Workers)** > **Workers & Pages**. | |
3. Go to **Compute (Workers)** > **Workers & Pages**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsparkdev You're right.
In Cloudflare Docs:
Pages offers support for GitHub and GitLab. To create your first Pages project:
- Log in to the Cloudflare dashboard and select your account.
- In Account Home, select Workers & Pages.
- Select Create application > Pages > Connect to Git.
It seems that after login/selecting an account, you are in Account Home. Do we need to point out this?
3. Go to **Account Home** > **Compute (Workers)** > **Workers & Pages**. | |
3. In Account Home, select **Compute (Workers)** > **Workers & Pages**. |
Or just apply your change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems right to describe it in the official documentation :)
Yeah as I said, for multi accounts you need to select the account after login, but I think that is already described. However I just attached the Cloudflare Dashboard flow as a screencast, for others to compare with the written steps, hope that helps: Screen.Recording.2025-01-30.at.06.54.29.mov |
Thanks for jumping in everyone!! I will note, this is why we try to describe other services, dashboards etc. as generally as possible because we can't control (and often don't know) when these update. As evidenced by the maintenance burden this is causing now. 😅 I would be fine with a PR suggestion that describes what you need to do accurately, but I would prefer as much of a generic, future proof solution as possible. e.g. If you have to set something on "Workers and Pages", then it's not our job to say exactly how to get there. Their own docs should explain where Workers and Pages is in their UI and how to get there. In fact, if there's no guarantee that that setting will always even be found at "Workers and Pages", it is most future proof to just specify the setting that needs configuring, and someone can find that setting through Cloudflare's own documentation about setting that value. The frequency with which a setting, action, or option name changes is much lower than the frequency with which the dashboard or UI could get updated or rearranged. So with that in mind, I'll ask you to give a fresh look over these instructions and see what, if anything, can be generalized for future-proof instructions! It's not our job to teach Cloudflare's current dashboard/UI -- only to let Cloudflare users know what must be configured to work with an Astro project! |
If we want it general, maybe we need to change it back to the original style. Something like:
|
That honestly looks amazing to me! Does that satisfy the original need for updating this page? |
I don't mind changing to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP. IT. 🥳
Description (required)
The steps to deploy with git are still strange.
Related issues & labels (optional)