Fix markdoc render code block in if tag #12930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6200182 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bluwy
commented
Jan 8, 2025
Comment on lines
-38
to
-41
| export const ComponentNode = createComponent({ | ||
| factory(result: any, { treeNode }: { treeNode: TreeNode }) { | ||
| if (treeNode.type === 'text') return render`${treeNode.content}`; | ||
|
|
There was a problem hiding this comment.
It might look like I'm doing a lot of change here, but I'm only extracting the factory function here out so I can call itself for arrays. Disabling whitespace in diff should make it easier to review.
ematipico
approved these changes
Jan 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #11656
The core of the issue is that sometimes Markdoc AST may return arrays within arrays (in
node.children), e.g. in if tags, content within the if tag are grouped as an array. This PR handles that and refactors the rendering code slightly.Testing
Added tests
Docs
n/a. bug fix