fix: conditionally import image style #12925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d928cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12925 will not alter performanceComparing Summary
|
github-actions
bot
added
the
pkg: integration
ascorbic
commented
Jan 8, 2025
| @@ -26,15 +26,15 @@ describe('Content Collections - render()', () => { | |||
| assert.equal($('ul li').length, 3); | |||
|
|
|||
| // Includes styles | |||
| assert.equal($('link[rel=stylesheet]').length, 2); | |||
| assert.equal($('link[rel=stylesheet]').length, 1); | |||
There was a problem hiding this comment.
There are all tests that were changed when experimental images were added. This is just changing them back.
bluwy
approved these changes
Jan 8, 2025
ascorbic
force-pushed
the
conditional-img-style
branch
from
d7bbb08 to
22c58a2
Compare
ematipico
approved these changes
Jan 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Responsive images need to include global styles, and currently these are being included even if responsive images are not enabled. This PR adds wrapper components that just add the styles to the main component, and conditionally export these according to whether the flag is enabled. This is temporary until the feature is unflagged.
Alongside #12921, this fixes #12868
Testing
Adds tests to ensure the styles aren't added to sites without the flag enabled. There are existing tests that check that they are added to pages that do have them enabled.
This also adds tests to the MDX integration that were needed for #12921 and are now possible. These check whether the styles are being applied to pages with no images.
Docs