Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inert attribute to boolean list #12729

Merged

Conversation

JoeMorgan
Copy link
Contributor

Changes

  • Addresses #12727 by adding inert to htmlBooleanAttributes

Testing

No functional changes, just adding a missing boolean attribute to be handled in the correct manner.

Docs

Simply addresses a minor defect.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 1487a89

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 12, 2024
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #12729 will not alter performance

Comparing JoeMorgan:add-inert-attribute-to-boolean-list (1487a89) with main (72f30dd)

Summary

✅ 4 untouched benchmarks

@JoeMorgan
Copy link
Contributor Author

JoeMorgan commented Dec 12, 2024

Test failure looks like a flake...Actually it seems as if the ubunto-latest (node@22) suite is failing for all PRs:

Screenshot 2024-12-12 at 4 39 34 PM

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good to me

@ascorbic ascorbic merged commit 8b1cecd into withastro:main Dec 13, 2024
15 of 16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 13, 2024
@JoeMorgan JoeMorgan deleted the add-inert-attribute-to-boolean-list branch December 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants