Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): let sync throw in check #12726

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix(cli): let sync throw in check #12726

merged 3 commits into from
Dec 13, 2024

Conversation

florian-lefebvre
Copy link
Member

Changes

Testing

Manually

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 90c0451

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Dec 12, 2024
github-actions[bot]
github-actions bot previously requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #12726 will not alter performance

Comparing fix/check-sync (878930c) with main (8b1cecd)

Summary

✅ 4 untouched benchmarks

@florian-lefebvre florian-lefebvre merged commit 7c7398c into main Dec 13, 2024
16 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/check-sync branch December 13, 2024 15:37
@astrobot-houston astrobot-houston mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
2 participants
@florian-lefebvre @Princesseuh