Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-astro): use CLI version tag to determine astro version #12529

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix(create-astro): use CLI version tag to determine astro version #12529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4a491f2
Fix: Use ref passed by user to get version in create astro
apatel369 Nov 26, 2024
421f768
fix tag name
apatel369 Nov 27, 2024
4bde0d0
improve changeset
apatel369 Nov 27, 2024
cfd35f5
parse tag from command
apatel369 Nov 30, 2024
3507123
cleanup
apatel369 Nov 30, 2024
4acb683
improve changeset
apatel369 Nov 30, 2024
ddb82a5
Merge branch 'main' into arpan-#12506-ref
apatel369 Dec 3, 2024
a116f13
Merge branch 'main' into arpan-#12506-ref
apatel369 Dec 4, 2024
06aede7
Merge branch 'main' into arpan-#12506-ref
apatel369 Dec 8, 2024
3f28643
fallback to latest
apatel369 Dec 8, 2024
8a6bcbd
format
apatel369 Dec 8, 2024
ec2999d
Merge branch 'main' into arpan-#12506-ref
bluwy Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-bulldogs-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

Fixes an issue where installing Astro beta using `create-astro` displays the wrong Astro version in the installation messages.
9 changes: 8 additions & 1 deletion packages/create-astro/src/actions/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ export interface Context {
}

export async function getContext(argv: string[]): Promise<Context> {
const packageSpecifier = argv
.find((argItem) => /^(astro|create-astro)@/.exec(argItem))
?.split('@')[1];
// Fallback to 'latest' if it's a version number
const packageTag =
packageSpecifier && /^v?\d[^a-zA-Z]*$/.test(packageSpecifier) ? 'latest' : packageSpecifier;
Comment on lines +41 to +42
Copy link
Member

@bluwy bluwy Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we play a bit safer here and only allow known tags? e.g.

switch (packageSpecifier) {
  case 'alpha':
  case 'beta':
  case 'rc':
    return packageSpecifier;
  default:
    return 'latest'
}

The code here is inferring the tag between create-astro and astro, and they might not match if we're loosely passing them.


const flags = arg(
{
'--template': String,
Expand Down Expand Up @@ -93,7 +100,7 @@ export async function getContext(argv: string[]): Promise<Context> {
prompt,
packageManager,
username: getName(),
version: getVersion(packageManager, 'astro', process.env.ASTRO_VERSION),
version: getVersion(packageManager, 'astro', packageTag, process.env.ASTRO_VERSION),
skipHouston,
fancy,
add,
Expand Down
4 changes: 2 additions & 2 deletions packages/create-astro/src/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ export const getName = () =>
});
});

export const getVersion = (packageManager: string, packageName: string, fallback = '') =>
export const getVersion = (packageManager: string, packageName: string, packageTag = 'latest', fallback = '') =>
new Promise<string>(async (resolve) => {
let registry = await getRegistry(packageManager);
const { version } = await fetch(`${registry}/${packageName}/latest`, {
const { version } = await fetch(`${registry}/${packageName}/${packageTag}`, {
redirect: 'follow',
})
.then((res) => res.json())
Expand Down
Loading