Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script injection during build #12392

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Fix script injection during build #12392

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ca1cba3
fix issue with scripts in `injectRoute` shared entrypoint
apatel369 Nov 7, 2024
40584b4
add changeset
apatel369 Nov 7, 2024
91503c8
Merge branch 'withastro:main' into arpan-#12171
apatel369 Nov 10, 2024
c766c32
add tests
apatel369 Nov 11, 2024
32a0832
add params
apatel369 Nov 11, 2024
fbd137d
rename
apatel369 Nov 11, 2024
f15133d
fix error
apatel369 Nov 11, 2024
71a460b
add default value
apatel369 Nov 11, 2024
b2d4b4b
fix error
apatel369 Nov 11, 2024
1a576a6
fix tests
apatel369 Nov 11, 2024
5fc06ab
format
apatel369 Nov 11, 2024
5075448
Merge branch 'main' into arpan-#12171
apatel369 Nov 11, 2024
7ee36da
Update .changeset/slimy-pets-lick.md
apatel369 Nov 12, 2024
f1a8617
remove unused
apatel369 Nov 12, 2024
aa5e8a0
fix args
apatel369 Nov 12, 2024
54cd066
Merge branch 'main' into arpan-#12171
apatel369 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-pets-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fix issue where shared entrypoints in injectRoute() remove client-side scripts in SSR builds.
apatel369 marked this conversation as resolved.
Show resolved Hide resolved
32 changes: 13 additions & 19 deletions packages/astro/src/core/build/plugins/plugin-hoisted-scripts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import type { BuildOptions, Rollup, Plugin as VitePlugin } from 'vite';
import type { AstroSettings } from '../../../@types/astro.js';
import { viteID } from '../../util.js';
import type { BuildInternals } from '../internal.js';
import { getPageDataByViteID } from '../internal.js';
import { getPageDatasByHoistedScriptId } from '../internal.js';
import type { AstroBuildPlugin } from '../plugin.js';
import type { StaticBuildOptions } from '../types.js';
import { shouldInlineAsset } from './util.js';
Expand All @@ -12,7 +11,7 @@
}

export function vitePluginHoistedScripts(
settings: AstroSettings,

Check notice on line 14 in packages/astro/src/core/build/plugins/plugin-hoisted-scripts.ts

View workflow job for this annotation

GitHub Actions / Lint

lint/correctness/noUnusedFunctionParameters 

This parameter is unused.

Check notice on line 14 in packages/astro/src/core/build/plugins/plugin-hoisted-scripts.ts

View workflow job for this annotation

GitHub Actions / Lint

lint/correctness/noUnusedVariables 

This parameter is unused.
internals: BuildInternals,
): VitePlugin {
let assetsInlineLimit: NonNullable<BuildOptions['assetsInlineLimit']>;
Expand Down Expand Up @@ -73,23 +72,18 @@
shouldInlineAsset(output.code, output.fileName, assetsInlineLimit);
let removeFromBundle = false;
const facadeId = output.facadeModuleId!;
const pages = internals.hoistedScriptIdToPagesMap.get(facadeId)!;
for (const pathname of pages) {
const vid = viteID(new URL('.' + pathname, settings.config.root));
const pageInfo = getPageDataByViteID(internals, vid);
if (pageInfo) {
if (canBeInlined) {
pageInfo.hoistedScript = {
type: 'inline',
value: output.code,
};
removeFromBundle = true;
} else {
pageInfo.hoistedScript = {
type: 'external',
value: id,
};
}
for (const pageData of getPageDatasByHoistedScriptId(internals, facadeId)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you noticed from the Github bot comments, settings isn't used anymore, so we can remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks.

if (canBeInlined) {
pageData.hoistedScript = {
type: 'inline',
value: output.code,
};
removeFromBundle = true;
} else {
pageData.hoistedScript = {
type: 'external',
value: id,
};
}
}

Expand Down
14 changes: 4 additions & 10 deletions packages/astro/test/fixtures/reuse-injected-entrypoint/src/to-inject.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
---
---
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<title>Routing</title>
</head>
<body>
<h1>to-inject.astro</h1>
</body>
</html>
<h1>to-inject.astro</h1>
<script>
console.log('to-inject.astro');
</script>
26 changes: 24 additions & 2 deletions packages/astro/test/reuse-injected-entrypoint.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ const routes = [
description: 'matches /injected-a to to-inject.astro',
url: '/injected-a',
h1: 'to-inject.astro',
scriptContent: 'console.log("to-inject.astro");',
},
{
description: 'matches /injected-b to to-inject.astro',
url: '/injected-b',
h1: 'to-inject.astro',
scriptContent: 'console.log("to-inject.astro");',
},
{
description: 'matches /dynamic-a/id-1 to [id].astro',
Expand Down Expand Up @@ -60,7 +62,7 @@ describe('Reuse injected entrypoint', () => {
await fixture.build();
});

routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch }) => {
routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch, scriptContent }) => {
const isEndpoint = htmlMatch && !h1 && !p;

it(description, async () => {
Expand All @@ -85,6 +87,15 @@ describe('Reuse injected entrypoint', () => {
if (htmlMatch) {
assert.equal(html, htmlMatch);
}

if (scriptContent) {
const scriptTags = $('script[type="module"]').toArray();
const scriptFound = scriptTags.some((script) => {
const scriptText = $(script).text();
return scriptText.includes(scriptContent.trim());
});
assert(scriptFound, `Expected script content to be injected in SSG ${url}`);
}
});
});
});
Expand All @@ -105,7 +116,7 @@ describe('Reuse injected entrypoint', () => {
await devServer.stop();
});

routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch }) => {
routes.forEach(({ description, url, fourOhFour, h1, p, htmlMatch, scriptContent }) => {
// checks URLs as written above
it(description, async () => {
const html = await fixture.fetch(url).then((res) => res.text());
Expand All @@ -127,6 +138,17 @@ describe('Reuse injected entrypoint', () => {
if (htmlMatch) {
assert.equal(html, htmlMatch);
}

if (scriptContent) {
const scriptTags = $('script[type="module"]').toArray();
const scriptFound = scriptTags.some((script) => {
const scriptSrc = $(script).attr('src');
return (
scriptSrc && scriptSrc.includes('/to-inject.astro?astro&type=script&index=0&lang.ts')
);
});
assert(scriptFound, `Expected script content to be injected in dev ${url}`);
}
});
});
});
Expand Down
Loading