Fix: Use ref passed by user to get version in create astro

withastro · Nov 26, 2024 · 7990ec9 · 7990ec9
1 parent 0910a32
commit 7990ec9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/selfish-bulldogs-jog.md b/.changeset/selfish-bulldogs-jog.md
@@ -0,0 +1,5 @@
+---
+'create-astro': patch
+---
+
+Fixes an issue where the `getVersion` function was incorrectly using the `latest` tag instead of the user-specified `ref` to determine the Astro version.
diff --git a/packages/create-astro/src/actions/context.ts b/packages/create-astro/src/actions/context.ts
@@ -93,7 +93,7 @@ export async function getContext(argv: string[]): Promise<Context> {
 		prompt,
 		packageManager,
 		username: getName(),
-		version: getVersion(packageManager, 'astro', process.env.ASTRO_VERSION),
+		version: getVersion(packageManager, 'astro', process.env.ASTRO_VERSION, ref),
 		skipHouston,
 		fancy,
 		dryRun,

diff --git a/packages/create-astro/src/messages.ts b/packages/create-astro/src/messages.ts
@@ -60,10 +60,10 @@ export const getName = () =>
 		});
 	});
 
-export const getVersion = (packageManager: string, packageName: string, fallback = '') =>
+export const getVersion = (packageManager: string, packageName: string, fallback = '', ref = 'latest') =>
 	new Promise<string>(async (resolve) => {
 		let registry = await getRegistry(packageManager);
-		const { version } = await fetch(`${registry}/${packageName}/latest`, {
+		const { version } = await fetch(`${registry}/${packageName}/${ref}`, {
 			redirect: 'follow',
 		})
 			.then((res) => res.json())