Improve example OTAP script #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmo-wp
force-pushed
the
feature/improve-example-otap-script
branch
2 times, most recently
from
165a6e0 to
51c8697
Compare
|
Good to me |
LePailleurThibault
approved these changes
Oct 9, 2024
GwendalRaoul
approved these changes
Oct 16, 2024
| @@ -7,6 +7,27 @@ | |||
| import wirepas_mesh_messaging as wmm | |||
| import logging | |||
| from random import choice | |||
| import sys | |||
|
|
|||
| otap_delay_choices = [ | |||
There was a problem hiding this comment.
Initially I didn't really give it as an option because I'm not sure it is clear for our customer which value to choose.
But if you gave good answer to give when someone will ask if it must use 10 or 30 minutes, go for it :-)
There was a problem hiding this comment.
No clear guidelines to give on this point unfortunately but as this script starts to look more like a reference one rather than an example leaving the delay hardcoded feels a bit weird.
jmo-wp
force-pushed
the
feature/improve-example-otap-script
branch
from
51c8697 to
adeb959
Compare
…eneric usage of OTAP with delay action
jmo-wp
force-pushed
the
feature/improve-example-otap-script
branch
from
adeb959 to
2c4dfe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve it to support: