Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use gateway id list during otap #41

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

vg-wp
Copy link
Contributor

@vg-wp vg-wp commented Jan 16, 2024

Enables example_otap.py to perform OTAP from:

  • all gateways
  • a single Gateway
  • a list of Gateways

@vg-wp vg-wp requested a review from GwendalRaoul January 16, 2024 17:15
@vg-wp vg-wp force-pushed the feature/use_gateway_id_list_during_otap branch from 4f1f121 to f92c9fe Compare January 16, 2024 17:36
@@ -38,6 +38,10 @@
help="Network address concerned by scratchpad")
parser.add_argument('--file',
help="Scratcphad to use")
parser.add_argument("--gateway",
type=list,
help="Gateway list to use. If specified, the OTAP will be performed on given Gateway IDs",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we support also input of the gateway list from a file ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supported by default as we are using parser API.
So any parameter can come from cmd line or a file. File is passed to the script by prefixing it by @
Example:
example_otap.py --host ... --username ... @list_of_agateways

@vg-wp vg-wp force-pushed the feature/use_gateway_id_list_during_otap branch from 6659527 to 6c2c1e6 Compare January 18, 2024 10:18
@vg-wp vg-wp merged commit 6ace252 into main Jan 18, 2024
2 checks passed
@vg-wp vg-wp deleted the feature/use_gateway_id_list_during_otap branch January 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants