Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gtables and datasignals extensions #2948

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

Vurv78
Copy link
Contributor

@Vurv78 Vurv78 commented Dec 21, 2023

No idea why they weren't, but now gtables and datasignals register extensions so they can be disabled.

This is especially important for gtables as they are so exploitable..

I'd love to have them disabled by default but I don't think that's an option atm.
Will need to see just how many chips use them.

People can move to event remote which is more of a datasignals replacement but can easily be used to replace gtables too...

Copy link
Member

@Denneisk Denneisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtables still fulfill a small role in not requiring a chip to exist (I use this for checking if a "singleton" already exists), but otherwise I have no problem with this.

@Hazeofdream
Copy link
Contributor

vurv on his way to brick an obscure e2 from 2010 using gtables

@Vurv78 Vurv78 merged commit 67e3cbc into wiremod:master Dec 21, 2023
1 check failed
@Vurv78 Vurv78 deleted the gtable-ext branch December 21, 2023 07:57
@Denneisk
Copy link
Member

vurv on his way to brick an obscure e2 from 2010 using gtables

It's enabled by default (and hopefully it'll stay that way for a long while) so nothing changes, it's more like a warning sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants