Cerebro chart: Don't quote username or password elastic host settings begginning with ${? #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h ${?
Remove qoutes from auth variables beginning with ${?. This allows username or password
secrets to be interpolated from the environment without needing to provide the entire
config file as a custom secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove quotes from auth variables beginning with ${?.
This allows username or password secrets to be interpolated from the environment without needing to provide the entire config file as a custom secret. For my usecase, I have a common login for cerebro, so this allows me to inject that password in via a custom secret defined
envFromSecretRefand reference it from several elastic host config sections.