Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-11196] Generate schemas for <service>.yaml #4324

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

[WPB-11196] Generate schemas for <service>.yaml #4324

wants to merge 10 commits into from

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 31, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: throughput/ci-maintenance labels Oct 31, 2024
@fisx fisx changed the title [WPB-11196] Generate schema for cannon.yaml [WPB-11196] Generate schemas for <service>.yaml Oct 31, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 31, 2024
@fisx fisx force-pushed the WPB-11196-list-backend-config-options branch 6 times, most recently from 934b26b to 7978547 Compare November 4, 2024 16:01
@fisx fisx force-pushed the WPB-11196-list-backend-config-options branch from dca3af9 to 49e9e18 Compare November 5, 2024 12:40
@fisx fisx force-pushed the WPB-11196-list-backend-config-options branch from 49e9e18 to 72f2112 Compare November 5, 2024 15:41
MangoIV
MangoIV reviewed Nov 7, 2024
View reviewed changes
libs/extended/src/Servant/API/Extended.hs
Comment on lines +133 to +137
instance {-# OVERLAPPABLE #-} (ToJSON a) => MimeRender YAML a where
mimeRender _ = fromStrict . Y.encode

instance {-# OVERLAPPABLE #-} (FromJSON a) => MimeUnrender YAML a where
mimeUnrender _ = first show . Y.decodeEither' . toStrict
Copy link
Contributor

@MangoIV MangoIV Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to make this OVERLAPPABLE? I think making every instance that would overlap OVERLAPPING is the better UX as you wouldn't want to accidentally write a new instance for a more specific type, unaware that these instances exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangoIV MangoIV MangoIV left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @MangoIV @zebot