Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: localize some strings for a custom build (WPB-11703) 🍒 #3537

Open
wants to merge 3 commits into
base: release/candidate
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 21, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


StoryWPB-11703 [Android] “Report a bug” results in an email to Wire Zendesk - need to change this for C builds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some texts are not localized

Solutions

Move that to strings.xml file

Needs releases with:

  • GitHub link to other pull request

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and ohassine and removed request for a team October 22, 2024 07:23
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3537.apk is available for download

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3537.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant