fix: button keeps spinning when user starts a conversation and back (WPB-5862)

[yamilmedina]

WPB-5862 [Android] "Start conversation" button keeps spinning when user starts a conversation and clicks on back button.

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

When the user goes to open conversation, and comes back, the loading indicator keeps loading indefinitely.

Causes (Optional)

Not reassigning new state in view model.

Solutions

Fix it, and add missing checks in tests

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Test Results

860 tests   860 ✅  11m 15s ⏱️
118 suites    0 💤
118 files      0 ❌

Results for commit 916eda4.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!