fix: Shields not shown in group participants list [WPB-10255] #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
mchenani,
Garzas and
saleniuk
echoes-hq
bot
added
the
echoes: bugs
alexandreferris
approved these changes
Aug 2, 2024
Test Results860 tests 860 ✅ 8m 36s ⏱️ Results for commit db8e023. ♻️ This comment has been updated with latest results. |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
saleniuk
approved these changes
Aug 2, 2024
borichellow
deleted the
fix/shields_not_shown_in_group_participants_list
branch
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
In group participance screen: green shields (E2EI verification) are not shown anymore
Causes (Optional)
Small "if null" mistake in mapping E2EI into "is verified" boolean.
Solutions
Fix it and add tests to cover that case