Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use sft for one on one calls when needed cherrypick 4.6 #3235

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #3225

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value echoes: technical-debt Changes intended at mitigating risks echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast echoes/initiative: product-metrics-in-countly Analytics and KPIs labels Jul 26, 2024
@ohassine ohassine changed the base branch from release/candidate to release/cycle-4.6 July 26, 2024 10:39
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test Results

860 tests   860 ✅  14m 13s ⏱️
118 suites    0 💤
118 files      0 ❌

Results for commit 0df688c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link

sonarcloud bot commented Jul 26, 2024

@ohassine ohassine enabled auto-merge (squash) July 26, 2024 15:36
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine merged commit 968a868 into release/cycle-4.6 Jul 26, 2024
14 of 15 checks passed
@ohassine ohassine deleted the use-sft-for-OneOnOne-calls-when-needed-cherrypick-4.6 branch July 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-debt Changes intended at mitigating risks echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants