Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharing button is disabled [WPB-9947] #3217

Merged

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 22, 2024

TaskWPB-9947 [Android] Implement asset sending restriction


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

error in validating if file sharing is enabled/disabled

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title fix: sharing button is disabled wpb 9947 fix: sharing button is disabled [WPB-9947] Jul 22, 2024
Copy link
Contributor

github-actions bot commented Jul 22, 2024

Test Results

860 tests   860 ✅  11m 25s ⏱️
118 suites    0 💤
118 files      0 ❌

Results for commit fa9591f.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara merged commit b0f0538 into release/cycle-4.6 Jul 26, 2024
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the fix/sharing-button-is-disabled-WPB-9947 branch July 26, 2024 07:22
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants