fix: "All Android Release Notes" item is not clickable - 🍒 v4.7 [WPB-10125] #3214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Manual cherry-pick for v4.7 of this one: #3187
Issues
"All Android Release Notes" item on "What's new" screen is not clickable.
Solutions
Added key to
remember
to updateClickable
to be enabled for items after loading.Added this "All Android Release Notes" item with different id for the placeholder so that it doesn't jump to the bottom after loading is finished.
Handled errors when fetching or parsing RSS feed simply by returning empty release notes list.
Fixed clickable area for
RowItem
so that even if any padding is applied, the click indication will always be shown for the whole row.Also, fixed
DependenciesScreen
to be annotated with new@WireDestination
instead of@Destination
.Testing
How to Test
Open "What's new" section and try to click on "All Android Release Notes".
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.