feat: Remove Reply option for notifications in degraded conversation [WPB-7425] #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
vitorhugods,
mchenani,
ohassine and
saleniuk
Test Results857 tests 857 ✅ 14m 33s ⏱️ Results for commit 241ed12. ♻️ This comment has been updated with latest results. |
alexandreferris
approved these changes
Jul 8, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
vitorhugods
approved these changes
Jul 8, 2024
yamilmedina
approved these changes
Jul 8, 2024
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
borichellow
deleted the
feat/remove_reply_option_for_notifications_in_degraded_conversation
branch
echoes-hq
bot
added
the
echoes: bugs
b1pb1p
added
echoes: features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
Notification for the conversations that has degraded verifications status should not have "Reply" option.
Causes (Optional)
Wasn't implemented.
Solutions
Use update kalium version that has
isReplyAllowedfield inLocalNotification.Conversationand according to that flag add or remove such an option in notifications.Dependencies (Optional)
waiting kalium update to me merged (wireapp/kalium#2867)