Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send and recive ephemeral pings #1941

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cherry pick


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested review from a team, yamilmedina, borichellow, vitorhugods, mchenani and trOnk12 and removed request for a team July 13, 2023 12:58
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Test Results

454 tests  ±0   453 ✔️ ±0   21s ⏱️ +2s
  71 suites ±0       1 💤 ±0 
  71 files   ±0       0 ±0 

Results for commit aa700ac. ± Comparison against base commit 4354c47.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 414 failed.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1941 (aa700ac) into develop (4354c47) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #1941      +/-   ##
=============================================
- Coverage      36.73%   36.68%   -0.05%     
+ Complexity       820      819       -1     
=============================================
  Files            282      282              
  Lines          10974    10971       -3     
  Branches        1432     1434       +2     
=============================================
- Hits            4031     4025       -6     
  Misses          6542     6542              
- Partials         401      404       +3     
Impacted Files Coverage Δ
.../ui/home/conversations/MessageComposerViewModel.kt 66.79% <ø> (ø)
...android/ui/home/conversations/MessageExpiration.kt 0.00% <ø> (ø)
...etingmessages/EditSelfDeletingMessagesViewModel.kt 79.31% <0.00%> (-3.45%) ⬇️
...mposer/state/MessageCompositionInputStateHolder.kt 68.42% <0.00%> (ø)
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 62.83% <100.00%> (+0.88%) ⬆️
...e/android/ui/home/conversations/model/UIMessage.kt 46.54% <100.00%> (-0.58%) ⬇️
...e/conversations/selfdeletion/SelfDeletionMapper.kt 30.00% <100.00%> (-20.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4354c47...aa700ac. Read the comment docs.

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 420 succeeded.

The build produced the following APK's:

@tmspzz tmspzz added this pull request to the merge queue Jul 13, 2023
Merged via the queue into develop with commit b070c3d Jul 13, 2023
11 checks passed
@tmspzz tmspzz deleted the fix/send_and_recive_ephemeral_pings branch July 13, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants