feat: send self deleting pings and clean up (#1929)

wireapp · Jul 13, 2023 · 9365f1e · 9365f1e
1 parent 93669ba
commit 9365f1e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/.../home/conversations/details/editselfdeletingmessages/EditSelfDeletingMessagesViewModel.kt b/.../home/conversations/details/editselfdeletingmessages/EditSelfDeletingMessagesViewModel.kt
@@ -84,8 +84,8 @@ class EditSelfDeletingMessagesViewModel @Inject constructor(
                     state = state.copy(
                         isLoading = selfDeletingMessages.isEnforcedByTeam || !isSelfAnAdmin,
                         isEnabled = selfDeletingMessages.isEnforcedByGroup,
-                        remotelySelected = selfDeletingMessages.toDuration().toSelfDeletionDuration(),
-                        locallySelected = selfDeletingMessages.toDuration().toSelfDeletionDuration()
+                        remotelySelected = selfDeletingMessages.duration?.toSelfDeletionDuration(),
+                        locallySelected = selfDeletingMessages.duration?.toSelfDeletionDuration()
                     )
                 }
         }

diff --git a/...kotlin/com/wire/android/ui/home/conversations/details/options/GroupConversationOptions.kt b/...kotlin/com/wire/android/ui/home/conversations/details/options/GroupConversationOptions.kt
@@ -127,7 +127,7 @@ fun GroupConversationSettings(
                     title = stringResource(id = R.string.conversation_options_self_deleting_messages_label),
                     subtitle = stringResource(id = R.string.conversation_options_self_deleting_messages_description),
                     trailingOnText = if (state.selfDeletionTimer.isEnforced) {
-                        "(${state.selfDeletionTimer.toDuration().toSelfDeletionDuration().shortLabel.asString()})"
+                        "(${state.selfDeletionTimer.duration.toSelfDeletionDuration().shortLabel.asString()})"
                     } else {
                         null
                     },

diff --git a/...src/main/kotlin/com/wire/android/ui/home/conversations/selfdeletion/SelfDeletionMapper.kt b/...src/main/kotlin/com/wire/android/ui/home/conversations/selfdeletion/SelfDeletionMapper.kt
@@ -21,7 +21,7 @@ import com.wire.android.ui.home.messagecomposer.SelfDeletionDuration
 import kotlin.time.Duration
 
 object SelfDeletionMapper {
-    fun Duration.toSelfDeletionDuration(): SelfDeletionDuration = when (this) {
+    fun Duration?.toSelfDeletionDuration(): SelfDeletionDuration = when (this) {
         SelfDeletionDuration.TenSeconds.value -> SelfDeletionDuration.TenSeconds
         SelfDeletionDuration.OneMinute.value -> SelfDeletionDuration.OneMinute
         SelfDeletionDuration.FiveMinutes.value -> SelfDeletionDuration.FiveMinutes

diff --git a/...in/kotlin/com/wire/android/ui/home/newconversation/common/SelectParticipantsButtonsRow.kt b/...in/kotlin/com/wire/android/ui/home/newconversation/common/SelectParticipantsButtonsRow.kt
@@ -169,7 +169,7 @@ fun SelfDeletionTimerButton(
     isDisabled: Boolean,
     onSelfDeletionTimerClicked: () -> Unit
 ) {
-    val isSelected = selfDeletionTimer is SelfDeletionTimer.Enabled && selfDeletionTimer.userDuration != ZERO
+    val isSelected = selfDeletionTimer is SelfDeletionTimer.Enabled && selfDeletionTimer.duration != null
     Box(
         modifier = modifier
             .padding(start = dimensions().spacing16x)

diff --git a/app/src/main/kotlin/com/wire/android/ui/sharing/ImportMediaScreen.kt b/app/src/main/kotlin/com/wire/android/ui/sharing/ImportMediaScreen.kt
@@ -62,9 +62,9 @@ import com.wire.android.util.CustomTabsHelper
 import com.wire.android.util.extension.getActivity
 import com.wire.android.util.ui.LinkText
 import com.wire.android.util.ui.LinkTextData
+import com.wire.kalium.logic.util.isPositiveNotNull
 import kotlinx.collections.immutable.persistentMapOf
 import kotlinx.coroutines.flow.SharedFlow
-import kotlin.time.Duration
 
 @Composable
 fun ImportMediaScreen(
@@ -169,7 +169,7 @@ fun ImportMediaRegularContent(authorizedViewModel: ImportMediaAuthenticatedViewM
         )
         MenuModalSheetLayout(
             menuItems = SelfDeletionMenuItems(
-                currentlySelected = authorizedViewModel.importMediaState.selfDeletingTimer.toDuration().toSelfDeletionDuration(),
+                currentlySelected = authorizedViewModel.importMediaState.selfDeletingTimer.duration.toSelfDeletionDuration(),
                 hideEditMessageMenu = importMediaScreenState::hideBottomSheetMenu,
                 onSelfDeletionDurationChanged = authorizedViewModel::onNewSelfDeletionTimerPicked,
             ),
@@ -261,8 +261,8 @@ private fun ImportMediaBottomBar(
     importMediaScreenState: ImportMediaScreenState
 ) {
     val selfDeletionTimer = importMediaViewModel.importMediaState.selfDeletingTimer
-    val shortDurationLabel = selfDeletionTimer.toDuration().toSelfDeletionDuration().shortLabel
-    val mainButtonText = if (selfDeletionTimer.toDuration() > Duration.ZERO) {
+    val shortDurationLabel = selfDeletionTimer.duration.toSelfDeletionDuration().shortLabel
+    val mainButtonText = if (selfDeletionTimer.duration.isPositiveNotNull()) {
         "${stringResource(id = R.string.self_deleting_message_label)} (${shortDurationLabel.asString()})"
     } else {
         stringResource(id = R.string.import_media_send_button_title)