Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: messages migration from proteus to mls [WPB-15149] 🍒 #3219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2025

BugWPB-15149 [Android] App is stuck after MLS migration

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When moving messages from proteus conversation to MLS if some message contained reactions or RestrictedAsset then migration failed causing slow sync to break.

Solutions

Migrate MessageRestrictedAssetContent and Reaction tables to update on cascade when Message is changing conversation_id

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  1. Before enabling mls add reactions to messages on 1on1 conversation
  2. Enable MLS for the team
  3. Trigger slow sync on both clients in the same 1on1 conversation
  4. App should not stuck on sync and user should see that current 1on1 conversation is using MLS protocol

Attachments (Optional)

Wire 2025-01-08 at 3_34 PM

@yamilmedina yamilmedina enabled auto-merge January 9, 2025 15:17
@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Jan 9, 2025
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Contributor Author

github-actions bot commented Jan 9, 2025

Test Results

0 tests   - 3 386   0 ✅  - 3 278   0s ⏱️ - 5m 36s
0 suites  -   581   0 💤  -   108 
0 files    -   581   0 ❌ ±    0 

Results for commit 9b8b3a4. ± Comparison against base commit 5788184.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Jan 9, 2025

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/messages-to-mls-conv-migration-cherry-pick
Commit report: 60307b4
Test service: kalium-jvm

✅ 0 Failed, 300 Passed, 13 Skipped, 41.93s Total Time

@yamilmedina yamilmedina requested review from a team, m-zagorski, alexandreferris, vitorhugods, ohassine and emmaoke-w and removed request for a team January 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... Fix PR Title 🤦‍♂️ 🚨 Potential breaking changes 👕 size: L type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants