refactor: remove the fetch of self user when only the ID is used [WPB-3726]

[MohamadJaara]

WPB-3726 [Android] Performance

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

i many places the calling code is fetching self user from remote when it does not needs to and it can get the id from cache

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 371 tests  ±0   3 264 ✅ ±0   5m 40s ⏱️ +16s
  578 suites ±0     107 💤 ±0 
  578 files   ±0       0 ❌ ±0 

Results for commit ee3c4f1. ± Comparison against base commit ecdca03.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	refactor/remove-fetching-of-self-user-when-only-the-id-is-used
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	678.13
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	403,067.17
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,345,550.01
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,516.15

🐰 View full continuous benchmarking report in Bencher

[datadog-wireapp]

Datadog Report

Branch report: refactor/remove-fetching-of-self-user-when-only-the-id-is-used
Commit report: bbf47d8
Test service: kalium-jvm

✅ 0 Failed, 3264 Passed, 107 Skipped, 1m 2.95s Total Time

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.12%. Comparing base (ecdca03) to head (ee3c4f1).

Files with missing lines	Patch %	Lines
...n/com/wire/kalium/logic/feature/call/CallsScope.kt	0.00%	4 Missing ⚠️
.../com/wire/kalium/logic/feature/debug/DebugScope.kt	0.00%	4 Missing ⚠️
...ium/logic/feature/debug/SendConfirmationUseCase.kt	0.00%	3 Missing ⚠️
.../com/wire/kalium/logic/data/user/UserRepository.kt	0.00%	1 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt	0.00%	1 Missing ⚠️
...ic/feature/conversation/MembersToMentionUseCase.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3196      +/-   ##
===========================================
- Coverage    54.12%   54.12%   -0.01%     
===========================================
  Files         1262     1262              
  Lines        36756    36754       -2     
  Branches      3734     3733       -1     
===========================================
- Hits         19896    19894       -2     
  Misses       15421    15421              
  Partials      1439     1439              

Files with missing lines	Coverage Δ
...kalium/logic/data/call/CallingParticipantsOrder.kt	100.00% <100.00%> (+3.70%)	⬆️
...ic/feature/call/usecase/GetIncomingCallsUseCase.kt	89.65% <ø> (ø)
.../com/wire/kalium/logic/data/user/UserRepository.kt	67.95% <0.00%> (-0.10%)	⬇️
...um/logic/feature/conversation/ConversationScope.kt	0.00% <0.00%> (ø)
...ic/feature/conversation/MembersToMentionUseCase.kt	77.14% <50.00%> (ø)
...ium/logic/feature/debug/SendConfirmationUseCase.kt	0.00% <0.00%> (ø)
...n/com/wire/kalium/logic/feature/call/CallsScope.kt	0.00% <0.00%> (ø)
.../com/wire/kalium/logic/feature/debug/DebugScope.kt	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdca03...ee3c4f1. Read the comment docs.