Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return all incoming calls [WPB-10430] #3068

Open
wants to merge 2 commits into
base: release/candidate
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 22, 2024

BugWPB-10430 [Android] When 2 Incoming call notifications at the same time, the app only displays one


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The use case to return incoming calls was not emitting updated list of incoming calls when another incoming call appeared.

Causes

Use case had a distinctUntilChanged which was comparing first element on the list and it was not emitting new list if the first element hasn't changed.

Solutions

Make the use case propagate incoming call list changes when more calls appear.

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Test Results

3 251 tests  +1   3 145 ✅ +1   4m 32s ⏱️ -1s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 74b70fc. ± Comparison against base commit 35cfb92.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (35cfb92) to head (74b70fc).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3068   +/-   ##
==================================================
  Coverage              52.70%   52.70%           
==================================================
  Files                   1317     1317           
  Lines                  51108    51107    -1     
  Branches                4742     4741    -1     
==================================================
+ Hits                   26937    26938    +1     
+ Misses                 22246    22244    -2     
  Partials                1925     1925           
Files with missing lines Coverage Δ
...ic/feature/call/usecase/GetIncomingCallsUseCase.kt 89.65% <ø> (+2.98%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cfb92...74b70fc. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/return-all-incoming-calls
Commit report: 4c3d56b
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 106 Skipped, 34.06s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants