Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: random decryption errors after ending 1:1 on SFT (WPB-11213) 🍒 🍒 #3039

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2024

BugWPB-11213 [Android] Decryption errors after ending 1:1 call sometimes received

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some random decryption errors after ending 1:1 on SFT.

Causes (Optional)

A race condition when we try to delete or decrypt a message related to the call and the sub conversation.

Solutions

Ignore MlsException to not show the decryption
(iOS and web already ignoring it)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Co-authored-by: Oussama Hassine <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch type: bug / fix 🐞 👕 size: XS labels Sep 25, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link
Contributor Author

github-actions bot commented Sep 26, 2024

Test Results

3 205 tests  ±0   3 098 ✅ ±0   3m 46s ⏱️ +13s
  551 suites ±0     107 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit 6e53241. ± Comparison against base commit ba79287.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

🐰 Bencher Report

Branchignore-mls-exception-cherry-pick-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
699,486.47
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
380,560,404.85
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
952,565,532.37
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,323,509.58
🐰 View full continuous benchmarking report in Bencher

@ohassine ohassine added this pull request to the merge queue Sep 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (ba79287) to head (6e53241).

Files with missing lines Patch % Lines
...r/conversation/message/MLSMessageFailureHandler.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3039      +/-   ##
===========================================
- Coverage    52.51%   52.51%   -0.01%     
===========================================
  Files         1301     1301              
  Lines        50034    50035       +1     
  Branches      4661     4662       +1     
===========================================
- Hits         26275    26274       -1     
- Misses       21882    21883       +1     
- Partials      1877     1878       +1     
Files with missing lines Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 29.62% <ø> (ø)
...r/conversation/message/MLSMessageFailureHandler.kt 35.71% <0.00%> (-2.75%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba79287...6e53241. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: ignore-mls-exception-cherry-pick-cherry-pick
Commit report: e53d735
Test service: kalium-jvm

✅ 0 Failed, 3098 Passed, 107 Skipped, 12.62s Total Time

Merged via the queue into develop with commit f2dc281 Sep 26, 2024
22 checks passed
@ohassine ohassine deleted the ignore-mls-exception-cherry-pick-cherry-pick branch September 26, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants