-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: random decryption errors after ending 1:1 on SFT (WPB-11213) 🍒 🍒 #3039
fix: random decryption errors after ending 1:1 on SFT (WPB-11213) 🍒 🍒 #3039
Conversation
Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
Quality Gate passedIssues Measures |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3039 +/- ##
===========================================
- Coverage 52.51% 52.51% -0.01%
===========================================
Files 1301 1301
Lines 50034 50035 +1
Branches 4661 4662 +1
===========================================
- Hits 26275 26274 -1
- Misses 21882 21883 +1
- Partials 1877 1878 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3098 Passed, 107 Skipped, 12.62s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Some random decryption errors after ending 1:1 on SFT.
Causes (Optional)
A race condition when we try to delete or decrypt a message related to the call and the sub conversation.
Solutions
Ignore MlsException to not show the decryption
(iOS and web already ignoring it)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.