fix: update group state when fetching conversation during slow sync WPB-11247 🍒 🍒 #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
typfel
approved these changes
Sep 25, 2024
MohamadJaara
approved these changes
Sep 25, 2024
typfel
force-pushed
the
fix/mls-re-login-WPB-11247-cherry-pick-cherry-pick
branch
from
bb1e765
to
92ee41d
Compare
|
Bencher Report| Branch | fix/mls-re-login-WPB-11247-cherry-pick-cherry-pick |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 697,098.43 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 776,616,582.94 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 937,924,985.41 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,584,727.42 |
Datadog ReportBranch report: ✅ 0 Failed, 3102 Passed, 107 Skipped, 14.3s Total Time |
typfel
force-pushed
the
fix/mls-re-login-WPB-11247-cherry-pick-cherry-pick
branch
2 times, most recently
from
a696ea2
to
8e8ce01
Compare
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
typfel
force-pushed
the
fix/mls-re-login-WPB-11247-cherry-pick-cherry-pick
branch
from
8e8ce01
to
432c327
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3037 +/- ##
===========================================
+ Coverage 52.52% 52.61% +0.09%
===========================================
Files 1301 1301
Lines 50044 50044
Branches 4663 4663
===========================================
+ Hits 26284 26331 +47
+ Misses 21883 21832 -51
- Partials 1877 1881 +4 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
typfel
deleted the
fix/mls-re-login-WPB-11247-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Group state isn't updated during the slow sync, which means MLS conversation will keep the
ESTABLISHEDstate even though they no longer exists inside CoreCrypto if we registered a new client.Causes
mls_group_stateis not included the "on conflict" clause.Solutions
Include it
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.