Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 when getting client domain crl [WPB-11243] #3026

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. 404 when getting client domain crl
  2. app setting the crl protocol to http regardless of what is set ap

Solutions

  1. add only the crl host to the path of the proxy url
  2. remove the hard codded protocol

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to cleanup AndroidManifest by removing android:usesCleartextTraffic="true"

@MohamadJaara
Copy link
Member Author

We also need to cleanup AndroidManifest by removing android:usesCleartextTraffic="true"

this one i will leave it out of the scope for this release since the url coming from remote can be http

@MohamadJaara MohamadJaara changed the title fix: 404 when getting client domain crl fix: 404 when getting client domain crl [WPB-11243] Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Test Results

2 930 tests   2 807 ✔️  26s ⏱️
   497 suites     123 💤
   497 files           0

Results for commit 96d8c37.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 24, 2024

Datadog Report

All test runs 810bc1d 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2807 123 2.04s Link
kalium-jvm 0 0 0 2960 107 5.16s Link

@MohamadJaara MohamadJaara merged commit 07641c6 into release/android-cycle-4.6 Sep 24, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the fix/crl-proxy-request-returning-404 branch September 24, 2024 16:51
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
* fix: 404 when getting client domain crl

* detekt
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
* fix: 404 when getting client domain crl

* detekt

Co-authored-by: Mohamad Jaara <[email protected]>
github-actions bot added a commit that referenced this pull request Sep 25, 2024
* fix: 404 when getting client domain crl

* detekt

Co-authored-by: Mohamad Jaara <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
…3038)

* fix: 404 when getting client domain crl

* detekt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants