Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) 🍒 #3019

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 18, 2024

BugWPB-10743 [Android] Use proper MLS removal key with federated 1:1 conversations

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fetch and set removal-keys from the create-conversation response for 1on1 conversations and only APIV6

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts to solve as well

@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Sep 25, 2024
Copy link
Contributor Author

github-actions bot commented Sep 25, 2024

Test Results

3 205 tests  +2   3 098 ✔️ +2   3m 23s ⏱️ -34s
   548 suites ±0      107 💤 ±0 
   548 files   ±0          0 ±0 

Results for commit 26555fc. ± Comparison against base commit 8268f21.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 26, 2024

Datadog Report

Branch report: fix/federated-1on1-removal-keys-cherry-pick
Commit report: d6a26ac
Test service: kalium-jvm

✅ 0 Failed, 3098 Passed, 107 Skipped, 10.19s Total Time

@MohamadJaara MohamadJaara removed the echoes: bugs Technical or functional defects in the product label Sep 26, 2024
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 26, 2024
Merged via the queue into release/candidate with commit 1dd7cb2 Sep 26, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the fix/federated-1on1-removal-keys-cherry-pick branch September 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants