Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(migration): pick one-on-one proteus conversation in alphabetically order for MLS migration (WPB-10259)" 🍒 🍒 #3018

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2024

BugWPB-10259 [Android] : Duplicate 1:1 conversation - not showing one of the conv

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:


Reverts #2962

…on in al…" (#3008) (#3013)

This reverts commit 5cad6c8.

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product Fix PR Title 🤦‍♂️ 👕 size: S labels Sep 17, 2024
…arget-alphabetically-cherry-pick-cherry-pick
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Contributor Author

github-actions bot commented Sep 25, 2024

Test Results

3 201 tests   - 1   3 094 ✅  - 1   3m 54s ⏱️ -1s
  551 suites ±0     107 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit 3836089. ± Comparison against base commit 3d4468b.

This pull request removes 1 test.
com.wire.kalium.persistence.dao.ConversationDAOTest ‑ givenMultipleOneOnOneProteusConversationExisting_whenGettingOneOnOneConversationId_thenShouldReturnAlphabeticallyOrderedConversation[jvm]

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.52%. Comparing base (3d4468b) to head (3836089).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3018   +/-   ##
========================================
  Coverage    52.52%   52.52%           
========================================
  Files         1301     1301           
  Lines        50043    50043           
  Branches      4663     4663           
========================================
+ Hits         26286    26287    +1     
+ Misses       21884    21883    -1     
  Partials      1873     1873           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4468b...3836089. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: revert-2962-fix/pick-oneonone-migration-target-alphabetically-cherry-pick-cherry-pick
Commit report: 76af3bb
Test service: kalium-jvm

✅ 0 Failed, 3094 Passed, 107 Skipped, 13.09s Total Time

Merged via the queue into develop with commit d170dab Sep 25, 2024
19 of 22 checks passed
@MohamadJaara MohamadJaara deleted the revert-2962-fix/pick-oneonone-migration-target-alphabetically-cherry-pick-cherry-pick branch September 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product Fix PR Title 🤦‍♂️ 👕 size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants