Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: images form iOS are blocked when restrictions are applied [WPB-10830] 🍒 #3010

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2024

BugWPB-10830 [Android] Receiving images is prohibited when shared from iOS from col3 backend

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

images form iOS are blocked when restrictions are applied

Solutions

  1. check if file extention or mime type are valid
  2. if not then and only then. we check if the message have complete meta data

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added echoes: bugs Technical or functional defects in the product type: bug / fix 🐞 👕 size: S labels Sep 13, 2024
@MohamadJaara MohamadJaara force-pushed the fix/if-restrictions-are-on-mages-from-iOS-are-not-recived-cherry-pick branch from 94a6a38 to f1682d5 Compare September 15, 2024 16:48
Copy link

sonarcloud bot commented Sep 15, 2024

Copy link
Contributor Author

github-actions bot commented Sep 15, 2024

Test Results

3 200 tests  ±0   3 093 ✔️ ±0   4m 47s ⏱️ + 1m 13s
   548 suites ±0      107 💤 ±0 
   548 files   ±0          0 ±0 

Results for commit f1682d5. ± Comparison against base commit a04b87f.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/candidate@a04b87f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...m/logic/sync/receiver/asset/AssetMessageHandler.kt 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #3010   +/-   ##
====================================================
  Coverage                     ?   52.88%           
====================================================
  Files                        ?     1296           
  Lines                        ?    49938           
  Branches                     ?     4679           
====================================================
  Hits                         ?    26411           
  Misses                       ?    21624           
  Partials                     ?     1903           
Files with missing lines Coverage Δ
...m/logic/sync/receiver/asset/AssetMessageHandler.kt 66.66% <20.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04b87f...f1682d5. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/if-restrictions-are-on-mages-from-iOS-are-not-recived-cherry-pick
Commit report: 0fc64bd
Test service: kalium-jvm

✅ 0 Failed, 3093 Passed, 107 Skipped, 18.23s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 16, 2024
Merged via the queue into release/candidate with commit 6037016 Sep 16, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the fix/if-restrictions-are-on-mages-from-iOS-are-not-recived-cherry-pick branch September 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants