-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle the case where asset name can be missing [WPB-10830] 🍒 #3002
fix: handle the case where asset name can be missing [WPB-10830] 🍒 #3002
Conversation
@@ -79,7 +79,16 @@ internal class GetMessageAssetUseCaseImpl( | |||
}, { message -> | |||
when (val content = message.content) { | |||
is MessageContent.Asset -> { | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Quality Gate passedIssues Measures |
Datadog ReportBranch report: ✅ 0 Failed, 3093 Passed, 107 Skipped, 10.89s Total Time |
…3002) * Commit with unresolved merge conflicts * merge conflicts --------- Co-authored-by: Mohamad Jaara <[email protected]>
…3002) (#3012) * Commit with unresolved merge conflicts * merge conflicts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohamad Jaara <[email protected]>
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Causes (Optional)
in both cases if asset restriction is on then the message will not be handled correctly and in iOS case it will show prohibated asset, and in web case it will not be visable
Solutions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.