fix(mls-client): skip MLSClient registration if registered client is mlsCapable (WPB-10723) 🍒 #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: S
🚨 Potential breaking changes
labels
MohamadJaara
approved these changes
Sep 3, 2024
borichellow
approved these changes
Sep 4, 2024
…gistered-client-is-mlscapable-cherry-pick
Datadog ReportBranch report: ✅ 0 Failed, 3089 Passed, 107 Skipped, 12.54s Total Time |
…gistered-client-is-mlscapable-cherry-pick
…gistered-client-is-mlscapable-cherry-pick
…gistered-client-is-mlscapable-cherry-pick
echoes-hq
bot
added
the
echoes: bugs
…gistered-client-is-mlscapable-cherry-pick
|
vitorhugods
deleted the
fix/skip-mls-registration-if-registered-client-is-mlscapable-cherry-pick
branch
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2024
…mlsCapable (WPB-10723) 🍒 (#2988) * fix(mls-client): skip MLSClient registration if registered client is mlsCapable (#2987) * test: update to Mockative 2.0 syntax --------- Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…mlsCapable (WPB-10723) 🍒 (#2988) (#3032) * fix(mls-client): skip MLSClient registration if registered client is mlsCapable (#2987) * test: update to Mockative 2.0 syntax --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Check if the MLS Client has registered, then skip the registration.
Issues
When the user logs out without clearing the data, we were trying to register the exist MLSClient again; that lead to an error!
Solutions
If the client has registered before and the user log in again to continue on a previously established session no need to register the client again and simply skip the api call.
Testing
Test Coverage (Optional)
How to Test
Have a user with MLS Enabled on their team
1- Log in and log out without clearing the data
2- When you try to log in again with the same use, you should be able to proceed successfully
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.