feat: set the correct external sender key when creating MLS conversation [WPB-8592] 🍒 🍒 #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…set-the-correct-public-key-when-creating-MLS-conversation-cherry-pick-cherry-pick # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/MLSClientTest.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mls/CipherSuite.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/client/RegisterMLSClientUseCase.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/base/authenticated/client/ClientRequest.kt
|
Test Results2 429 tests - 629 2 414 ✔️ - 540 25s ⏱️ - 2m 52s Results for commit 5b057df. ± Comparison against base commit 7f3ce95. This pull request removes 3058 and adds 2429 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 15 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 2955 Passed, 105 Skipped, 12.93s Total Time |
MohamadJaara
requested review from
mchenani and
MohamadJaara
and removed request for
mchenani
MohamadJaara
approved these changes
Jun 5, 2024
mchenani
approved these changes
Jun 5, 2024
mchenani
deleted the
feat/set-the-correct-public-key-when-creating-MLS-conversation-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
when creating a new conversation, we need to set the server public key matching the default cipher suite
Solutions
select the matching signature from cipher suite
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.