Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass the MLS public key signature algorithm when updating MLS public keys [WPB-8592] 🍒 🍒 #2776

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 21, 2024

StoryWPB-8592 [Android] Add support for ECDSA ciphersuites

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

pass the MLS public key signature algorithm when updating MLS public keys

Solutions

whe getting the public key form MLS client also append the cipher suite used for that key and then mapped it to a signature algorithm that is used when uploading the key to the backend

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor Author

github-actions bot commented May 25, 2024

Test Results

3 041 tests  ±0   2 937 ✔️ ±0   3m 7s ⏱️ -27s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit 09f8e7d. ± Comparison against base commit 81cf9dc.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MohamadJaara MohamadJaara added this pull request to the merge queue May 29, 2024
@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/pass-signature-algorithm-when-registring-mls-client-cherry-pick-cherry-pick
Commit report: 2af4c1d
Test service: kalium-jvm

✅ 0 Failed, 2937 Passed, 104 Skipped, 10.51s Total Time

Merged via the queue into develop with commit e418022 May 29, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the feat/pass-signature-algorithm-when-registring-mls-client-cherry-pick-cherry-pick branch May 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants