Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show last deleted message [WPB-1899] #2754

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented May 10, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

All deleted messages were filtered from message previews

Causes (Optional)

Conversations showed last message before deleted message

Solutions

Remove deleted message previews filtering and introduce new Deleted content

Copy link
Contributor

github-actions bot commented May 10, 2024

Test Results

3 038 tests  ±0   2 934 ✔️ ±0   2m 56s ⏱️ -47s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit 98be085. ± Comparison against base commit dd7669e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/deleted-last-message
Commit report: 2634ad6
Test service: kalium-jvm

✅ 0 Failed, 2934 Passed, 104 Skipped, 9.25s Total Time

@Garzas Garzas added this pull request to the merge queue May 10, 2024
Merged via the queue into develop with commit 5b9d85f May 10, 2024
19 checks passed
@Garzas Garzas deleted the fix/deleted-last-message branch May 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants