-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ANRs when getting identities [WPB-8753] #2721
Conversation
Test Results2 166 tests - 866 2 160 ✔️ - 768 15s ⏱️ - 3m 0s Results for commit 6601bb7. ± Comparison against base commit a0bb7fa. This pull request removes 3032 and adds 2166 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 6 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…dentities-anrs-dev
Datadog ReportBranch report: ✅ 0 Failed, 2929 Passed, 104 Skipped, 13m 59.01s Wall Time |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
ANR when trying to get user or device identities.
Solutions
ObserveConversationMembersUseCase
was emitting the same items multiple times, especially when navigating in the app, and it was causing the spam ofgetUserIdentities
and probably overloadingCoreCrypto
, sodistinctUntilChanged
worked.Testing
Test Coverage (Optional)
How to Test
Navigate: group conversation -> details -> participants -> user profile -> 1:1 conversation -> back or conversation details
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.