Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unread self mention [WPB-5786] #2678

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • updating edited message without self mention caused unread self mention

Causes (Optional)

  • unread mention badge on conversations

Solutions

  • fix check if mentions contains self user id

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

mention cases:

Case 1:

  1. send a new message with 2 ppl mentioned
  2. only the 2 ppl should see the icon
  3. edit the message to remove one mention
  4. only 1 person should see the icon

Case 2:

1 . send a message without a mention and then edit to add a mention and everyone will see the icon

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Test Results

2 845 tests   2 716 ✔️  23s ⏱️
   486 suites     129 💤
   486 files           0

Results for commit fd73b88.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/candidate@f4a09b4). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2678   +/-   ##
====================================================
  Coverage                     ?   58.36%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1177           
  Lines                        ?    46173           
  Branches                     ?     4383           
====================================================
  Hits                         ?    26949           
  Misses                       ?    17262           
  Partials                     ?     1962           
Files Coverage Δ
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 68.42% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a09b4...fd73b88. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 22, 2024

Datadog Report

All test runs e5706f6 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2716 129 7m 5.09s Link
kalium-jvm 0 0 0 2846 123 8m 46.01s Link

@Garzas Garzas merged commit e5bc7ec into release/candidate Mar 25, 2024
26 checks passed
@Garzas Garzas deleted the fix/unread-self-mention branch March 25, 2024 09:21
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2024
Co-authored-by: Jakub Żerko <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants