Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable message composer only for degraded legal hold conversation status #2674

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 21, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sending messages is disabled when one of 1:1 conversation members is under legal hold even when both members consent to legal hold.

Causes (Optional)

Interaction is disabled not only when legal hold status for conversation is DEGRADED (it means that the app got connection update with MISSING_LEGALHOLD_CONSENT status for this other member) but also when the status is ENABLED, but it shouldn't be the case, because ENABLED legal hold status can happen only when both consent to legal hold so at this point both are allowed to send messages to each other.

Solutions

Disable interaction only when legal hold status for 1:1 conversation is DEGRADED.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Have 1:1 conversation with other team member and enable legal hold for that member.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Test Results

2 996 tests  ±0   2 875 ✔️ ±0   2m 35s ⏱️ +6s
   517 suites ±0      121 💤 ±0 
   517 files   ±0          0 ±0 

Results for commit aeb6e3e. ± Comparison against base commit 303de42.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
com.wire.kalium.logic.feature.conversation.ObserveConversationInteractionAvailabilityUseCaseTest ‑ givenConversationLegalHoldIsEnabled_whenInvokingInteractionForConversation_thenInteractionShouldBeLegalHold[jvm]
com.wire.kalium.logic.feature.conversation.ObserveConversationInteractionAvailabilityUseCaseTest ‑ givenConversationLegalHoldIsEnabled_whenInvokingInteractionForConversation_thenInteractionShouldBeEnabled[jvm]

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 21, 2024

Datadog Report

All test runs b4ce04b 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2104 38 11.1s Link
kalium-jvm 0 0 0 2875 121 9m 22.06s Link

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, mchenani, Garzas, e-lisa, alexandreferris, borichellow and MohamadJaara and removed request for a team, typfel, yamilmedina and e-lisa March 21, 2024 13:33
@saleniuk saleniuk added this pull request to the merge queue Mar 22, 2024
Merged via the queue into develop with commit f948098 Mar 22, 2024
20 checks passed
@saleniuk saleniuk deleted the fix/disable-msg-composer-only-for-degraded-legal-hold branch March 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants