Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to CC 1.0.0-rc14 (RC) #2119

Closed
wants to merge 3 commits into from

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 9, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Upgrade to CC 1.0.0-rc14 which includes keystore migrations
  • Perform minimal change to support proteus API in 1.0.0-rc14 which involves wrapping the init methods in runBlocking since they now suspend.
  • Disable MLS and E2EI implementations since we don't want to adopt the MLS changes in 1.0.0.rc14

Testing

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Unit Test Results

   429 files     429 suites   1m 50s ⏱️
2 344 tests 2 225 ✔️ 119 💤 0

Results for commit d984dc1.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 9, 2023

Datadog Report

All test runs 6b025f0 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 23 25 3s Link
kalium-jvm 0 0 0 2225 119 10m 38s Link

@typfel typfel force-pushed the chore/upgrade-cc-1.0.0.rc14 branch from a07c32b to e12a775 Compare October 10, 2023 09:05
@yamilmedina yamilmedina changed the title chore: upgrade to CC 1.0.0-rc14 chore: upgrade to CC 1.0.0-rc14 (RC) Oct 10, 2023
@typfel typfel closed this Oct 18, 2023
@typfel typfel deleted the chore/upgrade-cc-1.0.0.rc14 branch October 18, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants