Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade CC to 0.8.2 to avoid migration issue #2105

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Sep 28, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Application crashes upon upgrading from 4.2.5 with encrypted proteus storage enabled

Causes

{ "ProteusException": "applied migration V1__schema is different than filesystem one V1__schema,"
09-28 18:11:59.846 13291 13291 E featureId:sync: "cause": ii.h$b0: applied migration V1__schema is different than filesystem one V1__schema }"

Solutions

Downgrade CC back to 0.8.2 until DB migration is in place.

Notes

E2EI related I've TODO() since that's new API which doesn't exist in 0.8.2 but those code paths shouldn't be active anyway.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Unit Test Results

       6 files         6 suites   8m 1s ⏱️
2 238 tests 2 219 ✔️ 19 💤 0

Results for commit 664b225.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@151f59c). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2105   +/-   ##
====================================================
  Coverage                     ?   58.07%           
  Complexity                   ?       24           
====================================================
  Files                        ?     1004           
  Lines                        ?    37614           
  Branches                     ?     3433           
====================================================
  Hits                         ?    21844           
  Misses                       ?    14297           
  Partials                     ?     1473           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151f59c...664b225. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 28, 2023

Datadog Report

All test runs 2108e64 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2131 120 8m 31s Link
kalium-jvm 0 0 0 2238 108 9m 47s Link

@mchenani mchenani merged commit 49c569f into release/candidate Sep 28, 2023
15 checks passed
@mchenani mchenani deleted the fix/downgrade-core-crypto branch September 28, 2023 19:10
yamilmedina added a commit that referenced this pull request Oct 4, 2023
typfel added a commit that referenced this pull request Oct 9, 2023
typfel added a commit that referenced this pull request Oct 16, 2023
@typfel typfel mentioned this pull request Oct 16, 2023
6 tasks
typfel added a commit that referenced this pull request Oct 16, 2023
* Revert "fix: downgrade CC to 0.8.2 to avoid migration issue (#2105)"

This reverts commit 49c569f.

* chore: bump core-crypto to 1.0.0-pre.6+v1-schemafix-003
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
* Revert "fix: downgrade CC to 0.8.2 to avoid migration issue (#2105)"

This reverts commit 49c569f.

* chore: bump core-crypto to 1.0.0-pre.6+v1-schemafix-003
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants