feat: add logger with userId and clientId #2100
Conversation
There was a problem hiding this comment.
Nicely done!
Not only this adds the possibility of adding a User/Client to the logs, but it also fixes the issue where tags keep changing due to it being mutable inside KaliumLogger.
Just some suggestions to add Kdocs to the new Tag class and the fields/functions where it can be used
logger/src/commonMain/kotlin/com/wire/kalium/logger/KaliumLogger.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
@@ Coverage Diff @@
## release/candidate #2100 +/- ##
====================================================
Coverage ? 58.08%
Complexity ? 21
====================================================
Files ? 1004
Lines ? 37639
Branches ? 3436
====================================================
Hits ? 21862
Misses ? 14306
Partials ? 1471 Continue to review full report in Codecov by Sentry.
|
saleniuk
requested review from
a team,
gongracr,
yamilmedina,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
* feat: add logger with userid and clientid * update lib version * added some documentation to the KaliumLogger tags * moved creating string tag to Tag sealed class * fix detekt * fix tests
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently logs are not associated with specific user and client which makes debugging harder.
Solutions
Create a logger in user scope that can pass userId and clientId with each log.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.